Skip to content

Fix issue #663 #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

Fix issue #663 #796

merged 1 commit into from
Aug 13, 2025

Conversation

@marcioluis
Copy link
Contributor

@marcioluis marcioluis commented Aug 5, 2025 •
edited
Loading

This pull request fix issue #663 for alpha version 7.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@dhmlau
Copy link
Member

dhmlau commented Aug 11, 2025

@marcioluis, thanks for the PR. I just kicked off the CI.

@dhmlau
Copy link
Member

dhmlau commented Aug 11, 2025

@marcioluis, could you please take a look at the code lint and commit lint error?
For your reference, in the 6.x PR, the commit message was: fix: connection string seed list parsing.

@dhmlau
Copy link
Member

dhmlau commented Aug 12, 2025

@marcioluis, thanks for fixing the linting issues.
There are currently 2 tests failure. I believe the first one is related to your change. Could you please take a look?

1) connect
       should connect on cluster url connection string:
     MongoMissingCredentialsError: Cannot initialize connector undefined: Username required for mechanism 'SCRAM-SHA-256'
      at MongoCredentials.validate (node_modules/mongodb/lib/cmap/auth/mongo_credentials.js:109:19)
      at parseOptions (node_modules/mongodb/lib/connection_string.js:316:34)
      at new MongoClient (node_modules/mongodb/lib/mongo_client.js:48:63)
      at MongoDB.connect (lib/mongodb.js:115:483)
      at Object.initializeDataSource [as initialize] (lib/mongodb.js:25:457)
      at DataSource.setup (node_modules/loopback-datasource-juggler/lib/datasource.js:515:19)
      at new DataSource (node_modules/loopback-datasource-juggler/lib/datasource.js:147:8)
      at global.getDataSource.global.getSchema (test/init.js:31:8)
      at Context.<anonymous> (test/mongodb.test.js:148:23)
      at process.processImmediate (node:internal/timers:505:21)

@dhmlau dhmlau merged commit f585cf4 into loopbackio:master Aug 13, 2025
6 of 15 checks passed
@dhmlau
Copy link
Member

dhmlau commented Aug 13, 2025

@marcioluis, thanks for your contribution again. Your PR has been merged! 🎉

@marcioluis
Copy link
Contributor Author

marcioluis commented Aug 13, 2025

Awesome! Thank you very much for your time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau dhmlau approved these changes

@achrinza achrinza Awaiting requested review from achrinza achrinza is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcioluis @dhmlau